Fix for #1520 - Eliminate MySQL CAST on datetime columns when expected value type is datetime.
Areas validated
Querygenerators
CustomView
Reports (all types) with grouping.
Calendar
Merge request reports
Merged by
(Nov 24, 2025 1:05am UTC)
Activity
736 736 } 737 737 $values = explode(' ', $value); 738 738 if (count($values) == 2) { 739 $fieldSql .= "$fieldGlue CAST(CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) AS DATETIME) $valueSql "; 739 $fieldSql .= "$fieldGlue CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) $valueSql "; 740 740 } else { -
@akshath Alias name is also removed, please do review.
736 736 } 737 737 $values = explode(' ', $value); 738 738 if (count($values) == 2) { 739 $fieldSql .= "$fieldGlue CAST(CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) AS DATETIME) $valueSql "; 739 $fieldSql .= "$fieldGlue CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) $valueSql "; 740 740 } else { @uma.s this is not alias, it is the target type achieved using CAST method. Here we are concating and casting to datetime type which is not required as resultant value is alrady datetime.
736 736 } 737 737 $values = explode(' ', $value); 738 738 if (count($values) == 2) { 739 $fieldSql .= "$fieldGlue CAST(CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) AS DATETIME) $valueSql "; 739 $fieldSql .= "$fieldGlue CONCAT($dateFieldColumnName,' ',$timeFieldColumnName) $valueSql "; 740 740 } else { -
@akshath Thanks! for the clarification.
mentioned in commit 70b94148
Please register or sign in to reply